-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dependencies] Upgrade pymongo>4
and motor>3
.
#386
Comments
I now see that Looks like this was discussed before: #381 |
Alright - I opened a PR to allow I look forward to a review 🙇 Let me know how best to merge this. |
Hi. Than you for your interest in umongo. I think it is good practice to pin major versions so that everything does break when a new major dependency version is published. I totally agree with adding motor >=3,<4 support. Thanks for the PR. Indeed this is independent from txmongo support (#381). |
Hi @lafrech 👋
Thank you for maintaining
umongo
, a product we maintain depends on it! 🙇Lately it's come to our attention that we're not using the latest
pymongo
version and this is due toumongo[motor]
being pinned tomotor>2,<3
.Are you aware of a specific reason why motor is pinned
<3
?It started supporting
pymongo>4
after 3.0 unfortunately.If it helps I can open a PR to investigate motor 3.x support in umongo 🙌
The text was updated successfully, but these errors were encountered: