Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3tag: Update the manifest #14274

Closed

Conversation

FlawlessCasual17
Copy link
Contributor

  • Changed the context menu option to use registry files.

  • Changed the pre_install and pre_uninstall process so the explorer will no longer restart after either process.

  • Added a post_install process.

  • I have read the Contributing Guide.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mp3tag

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@FlawlessCasual17
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mp3tag

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@rasa
Copy link
Member

rasa commented Dec 29, 2024

/verify

Copy link
Contributor

Your changes do not pass checks.

mp3tag

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@rasa
Copy link
Member

rasa commented Dec 29, 2024

@FlawlessCasual17 The conflict is the entire file. Is one LF and one CRLF formatted?

@FlawlessCasual17
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mp3tag

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@FlawlessCasual17
Copy link
Contributor Author

@rasa I'm going to close this pull request and open a new one. Can you approve the new PR and pull that one please?

@FlawlessCasual17 FlawlessCasual17 deleted the mp3tag-patched branch December 29, 2024 20:40
@FlawlessCasual17
Copy link
Contributor Author

The new PR is here: #14654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants