hemmelig: Add version 1.0.0#16758
Conversation
WalkthroughAdds a new Windows package manifest Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. hemmelig
|
|
PRs labeled Please create a package request before submitting a PR to add a new package to this bucket. When creating a package request, you can check the criteria for a package to be accepted in this bucket, which can help you determine whether your PR is likely to be approved. The information provided in the issue can also help maintainers quickly get the necessary details.
|
|
Done: #16759 I have made the request in Extras, not Main, because the (only) criterium it does not meet is that it's not a developer tool (in the narrowest sense of the word). |
|
/verify |
|
All changes look good. Wait for review from human collaborators. hemmelig
|
|
@aliesbelik I'm trying to understand the changes made:
|
Exactly.
Redirect works for the repo GH link but not for the API endpoint (wonder if it was already changed/fixed): ScoopInstaller/Main#5215 (comment).
Adding hash to autoupdate. |
|
@aliesbelik Thanks for taking the time for explaining this. I'll go over my own bucket and see if it needs adjustments and I'll make sure to implement this in any future PRs. |
Co-authored-by: z-Fng <54583083+z-Fng@users.noreply.github.com>
z-Fng
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
The manifest will update automatically as the package updates, as long as the upstream releases new packages that follow the same pattern defined in the manifest. If there are any other changes, feel free to submit a PR.
- affinity: fix useragent version
It looks like redirects work for the GitHub API as well now. |
Good to know! Personally, I think using the repo ID is less user friendly/transparent, so I'd opt for changing this policy in Scoop manifests. |
|
Exactly. I'm also wondering if we can use the repo name directly in the GitHub API now, instead of the repository ID. It would be much more intuitive. We could even go a step further and use CI to fix/correct the repo links. |
|
Related to this PR, I've also been looking into how to deprecate the manifest in my own bucket, ideally making it "transition" to using the Extras bucket. I can't find anything actionable about this in the documentation, other than that I can move my manifest into the
I'm asking because this may always happen, in any bucket, without the user really noticing. |
No, there won't be.
Exactly. We are lacking the mechanisms to remove or replace a manifest now. See: ScoopInstaller/Main#7524 (comment) As a workaround, we typically add a deprecation notice to the existing manifest and then deprecate it in a few months. e.g., #17040 |
|
Got it. Maybe the smallest change to really improve things would be to list deprecated packages (just like with |
Adds Hemmelig CLI v1.0.0
https://github.com/HemmeligOrg/Hemmelig.app/releases/tag/cli-v1.0.0
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.