Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIPP version 2.5.9 #2050

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Add PIPP version 2.5.9 #2050

merged 2 commits into from
Apr 28, 2019

Conversation

MCOfficer
Copy link
Contributor

No description provided.

Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ash258
Copy link
Contributor

Ash258 commented Apr 28, 2019

Fixed manifest:

{
    "description": "An Application designed for pre-processing planetary images before stacking them with image stacking software such as Registax.",
    "homepage": "https://sites.google.com/site/astropipp/home",
    "version": "2.5.9",
    "license": {
        "identifier": "Freeware",
        "url": "https://sites.google.com/site/astropipp/home#TOC-Acknowledgements"
    },
    "architecture": {
        "64bit": {
            "url": "https://sites.google.com/site/astropipp/downloads/pipp_install_x64_2.5.9.zip",
            "hash": "231f08bf36aa812946158d6239861bd9a3a328d33124afd357a35dc28d623efe"
        },
        "32bit": {
            "url": "https://sites.google.com/site/astropipp/downloads/pipp_install_x86_2.5.9.zip",
            "hash": "87dfaa846e75e265a004961aa785b5544ec7cf8ae0cf4c7443a9c677172bba0d"
        }
    },
    "installer": {
        "script": [
            "(Get-ChildItem \"$dir\" '*.exe').FullName | Expand-7zipArchive -DestinationPath \"$dir\" -Removal",
            "Remove-Item \"$dir\\`$PLUGINSDIR\", \"$dir\\uninst.exe\" -Recurse"
        ]
    },
    "bin": "PIPP.exe",
    "shortcuts": [
        [
            "PIPP.exe",
            "PIPP"
        ]
    ],
    "checkver": {
        "url": "https://sites.google.com/site/astropipp/downloads",
        "regex": "Windows Installer \\(v([\\d\\.]+)\\)"
    },
    "autoupdate": {
        "architecture": {
            "64bit": {
                "url": "https://sites.google.com/site/astropipp/downloads/pipp_install_x64_$version.zip"
            },
            "32bit": {
                "url": "https://sites.google.com/site/astropipp/downloads/pipp_install_x86_$version.zip"
            }
        }
    }
}

@MCOfficer
Copy link
Contributor Author

You're godsent, I was still meddling around with the installer.

I still think it's Inno-based (at least that's what strings tells me), but you're right, in this case one can just extract it.
I'm divided about the license url, though - acknowledgements are fine and all, but it's not the license the installer gives you, in fact it's not a license at all. But i'll leave that question to you maintainers.

@r15ch13
Copy link
Member

r15ch13 commented Apr 28, 2019

I still think it's Inno-based (at least that's what strings tells me),

image
The Logo and string say it's an NSIS based installer 😕

@MCOfficer
Copy link
Contributor Author

MCOfficer commented Apr 28, 2019

i concede - that logo might've given it away, but not the footer... thanks dark theme 😄
grafik

Makes you wonder where this comes from o.O

λ» strings .\pipp_install_x64_2.5.9.exe | grep Inno
Inno Setup Setup Data (5.5.7)

@r15ch13
Copy link
Member

r15ch13 commented Apr 28, 2019

utvideo-16.1.0-win.exe
image

@r15ch13 r15ch13 changed the title Add PIPP v2.5.9 Add PIPP version 2.5.9 Apr 28, 2019
@r15ch13 r15ch13 merged commit fdda6e7 into ScoopInstaller:master Apr 28, 2019
@MCOfficer MCOfficer deleted the patch-1 branch April 28, 2019 11:07
MCOfficer added a commit to MCOfficer/scoop-bucket that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants