Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imo: Update to version 1.4.2.1 #9095

Merged
merged 9 commits into from
Aug 25, 2022

Conversation

SonaliBendre
Copy link
Contributor

@SonaliBendre SonaliBendre commented Aug 24, 2022

Closes #XXXX

Relates to #XXXX

@SonaliBendre
Copy link
Contributor Author

@issaclin32 I fixed checkver

@SonaliBendre
Copy link
Contributor Author

Loading ImoSetup_1.4.2.1_Release.exe from cache.
Checking hash of ImoSetup_1.4.2.1_Release.exe ... ok.
Running pre_install script...
ERROR Exit code was 5!
ERROR Exit code was 1622!
Failed to extract files from ~\scoop\apps\imo-messenger\1.4.2.1\extract\AttachedContainer\ImoInstaller.msi.
Log file:
  ~\scoop\apps\imo-messenger\1.4.2.1\extract\AttachedContainer\msi.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=imo-messenger%401.4.2.1%3a+decompress+error

@tech189
Copy link
Member

tech189 commented Aug 24, 2022

I get the same error and the extract folder is empty so I can't read that log file...

@issaclin32
Copy link
Member

issaclin32 commented Aug 25, 2022

There are 2 problems being fixed in that fix extraction commit:

  • A recent change in Scoop core (feat(core): Improve argument concatenation in Invoke-ExternalCommand Scoop#5065) breaks the compatibility, so we need to remove literal quotes from the arguments.
  • imo is currently at version 1.4.2.1, but the file contained in the MSI installer has imo\1.4.2.0 (I think there is a mistake when they packed the installer). Therefore we need to use wildcards (*) as a workaround.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@issaclin32
Copy link
Member

Our bots have problem accessing the checkver page https://imo.im/win/Version.txt

@github-actions

This comment was marked as outdated.

@issaclin32
Copy link
Member

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

imo-messenger

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@issaclin32 issaclin32 merged commit 1ea4206 into ScoopInstaller:master Aug 25, 2022
@SonaliBendre
Copy link
Contributor Author

@issaclin32 digitatrend js doesn't work. can you find a workaround for https://imo.im/win/Version.txt like proxy, etc.?

@SonaliBendre
Copy link
Contributor Author

@SonaliBendre
Copy link
Contributor Author

@issaclin32 can bot access this url?

@issaclin32
Copy link
Member

issaclin32 commented Aug 25, 2022

@issaclin32 digitatrend js doesn't work.

The page has JS generated content, but the version is in the non-JS part, so it will work for checkver. At least the test results proved it.

can you find a workaround for https://imo.im/win/Version.txt like proxy, etc.?

It is possible to implement something like that in checkver script, but I don't think it is necessary for now.

@issaclin32 https://womginx.arph.org/main/https://imo.im/win/Version.txt
@issaclin32 can bot access this url?

Sadly not. The content literally shows up as <script>location.href="/womginxaddcookie/"+Date.now()+"/"+location.href</script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants