Action/PR: Avoid $version in checkver script #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should really first investigate why the $version variables gets leaked out of the Invoke-Expression call here: https://github.com/ScoopInstaller/Scoop/blob/ac2fb38722fffca9dcea6e7faeda6f305f04ad9b/bin/checkver.ps1#L224, that too in the global scope (because it affects all subsequent checkver calls thereafter). /cc @niheaven |
5 tasks
|
Fixed by ScoopInstaller/Scoop#4941. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to help us avoid using
$versionin checkver script, which can cause some serious errors like #8494 and #8498.Another way to implement this is through schema.json,
but I think implementing this in PR handler is simpler and more readable.