Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose env, save config #4

Merged
merged 7 commits into from
May 10, 2019
Merged

expose env, save config #4

merged 7 commits into from
May 10, 2019

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented Mar 15, 2019 •
edited
Loading

rework of #3 , should close #2 (details in #2 (comment)), upstream ScoopInstaller/Scoop#3121

@chawyehsu chawyehsu mentioned this pull request Mar 15, 2019
Closed
@chawyehsu chawyehsu added the please-review Please review label Mar 15, 2019
@chawyehsu chawyehsu self-assigned this Mar 15, 2019
@chawyehsu chawyehsu requested a review from r15ch13 March 15, 2019 14:58
@chawyehsu chawyehsu added upstream Waiting for upstream and removed please-review Please review labels May 9, 2019
@chawyehsu chawyehsu mentioned this pull request May 10, 2019
Merged
1 task
@chawyehsu chawyehsu removed the upstream Waiting for upstream label May 10, 2019
@chawyehsu chawyehsu merged commit c8a0eee into ScoopInstaller:master May 10, 2019
@chawyehsu chawyehsu deleted the env branch May 10, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r15ch13 r15ch13 Awaiting requested review from r15ch13

Assignees

@chawyehsu chawyehsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variables
2 participants
@chawyehsu @h404bi