-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support using external git for initialization #40
Conversation
xxthunder
commented
Jan 23, 2023
•
edited
Loading
edited
- install.ps1 uses git for retrieval of Scoop and Main repo instead of downloading the zips.
- CI workflow runs install.ps1 and tests scoop availability after installation.
Our company's proxy forbids downloading the zipped repos (see ScoopInstaller/Scoop#5012 for details). So my workaround is to use 'git clone' instead when git is already installed (which is the case on our engineering machines). No idea if this is worth merging. Maybe it helps someone out there. 😄 |
I don't mind leveraging the existing |
@chawyehsu Thank you very much for your feedback. Currently we are using environment variables for doing this: HTTP_PROXY, HTTPS_PROXY and NO_PROXY. So no need for command line arguments. |
That's perfectly fine when you are using proxy environment variables, what I mean is if you do not pass those proxy settings to the Lines 43 to 50 in f1cf244
Lines 175 to 199 in f1cf244
|
Aaah, yes, now I got your point. Looking into it, will come back to you. |
95bf694
to
418f611
Compare
Okay, got the scoop installer and finally scoop running in GitHub action to see that it is actually working. @chawyehsu Any feedback is welcome. By the way, green finally: https://github.com/xxthunder/ScoopInstall/actions/runs/4114136831 |
@chawyehsu Finally found some time again. Thanks for pointing me to this Invoke-Git function. So I took over the env vars recovery. Tests are green: https://github.com/xxthunder/ScoopInstall/actions/runs/4368498689 Please review again when you have time. |
ce5051a
to
05afedb
Compare
Thank you for your contributions! 🎉 |
BeforeAll { | ||
# Load SUT | ||
$sut = (Split-Path -Leaf $PSCommandPath).Replace('.Tests.ps1', '.ps1') | ||
. ".\$sut" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this will actually trigger an installation of Scoop, it tries to expose functions for unit tests below but it imports the whole install script. I noticed it when implementing #76 and the ci kept failing. ;p