Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle git errors while cloning #59

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

xxthunder
Copy link
Contributor

@xxthunder xxthunder commented Jun 11, 2023

Reproduced 'git clone failure' as in #57 .

Close #57.

@xxthunder
Copy link
Contributor Author

@chawyehsu Something like this you had in mind?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
install.ps1 Outdated Show resolved Hide resolved
install.ps1 Outdated Show resolved Hide resolved
@xxthunder xxthunder force-pushed the master branch 2 times, most recently from f6b74df to 9db44a9 Compare June 18, 2023 14:45
@xxthunder xxthunder changed the title WIP: handle git errors while cloning Handle git errors while cloning Jun 18, 2023
@xxthunder xxthunder requested a review from chawyehsu June 18, 2023 14:47
@xxthunder
Copy link
Contributor Author

@chawyehsu Ready for review and merge.

Copy link
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chawyehsu chawyehsu merged commit 656e17b into ScoopInstaller:master Jul 2, 2023
magicedy added a commit to magicedy/scoop-bucket-m that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Installer should Respect transport protocol (git settings)
2 participants