Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winpython: Add 'extract_dir' #100

Merged
merged 1 commit into from
Jun 19, 2019
Merged

winpython: Add 'extract_dir' #100

merged 1 commit into from
Jun 19, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 30, 2019 •
edited
Loading

Example of innosetup: true w/ extract_dir.

Please MERGE AFTER ScoopInstaller/Scoop@e6b2e3d merged into master

PS: I don't like this manifest that use WinPython as pure Python distribution is a waste.

rasa
rasa approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed fine locally.

@rasa rasa merged commit 521d1e1 into ScoopInstaller:master Jun 19, 2019
@niheaven niheaven deleted the fix-winpython branch June 19, 2019 05:47
@Ash258
Copy link
Contributor

Ash258 commented Jun 19, 2019

I do not think that ScoopInstaller/Scoop#3466 is in master.

@niheaven
Copy link
Member Author

Just works fine for 'master', using old treatment for extract_dir and extract_to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasa rasa rasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niheaven @Ash258 @rasa