-
-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdu@5.1.0: Add manifest #2311
gdu@5.1.0: Add manifest #2311
Conversation
/verify |
All changes look good. Wait for review from human collaborators. gdu
|
Note that a PR for gdu is already open on ScoopInstaller/Extras#6098
|
How exactly does one measure 'popularity'? If we go by GitHub stars, gdu is more popular than a similar tool called dua (which is already in main bucket), and is just a year younger. I don't think popularity/age is the problem. This repository is effectively defunct, just look at the amount of trivial open PRs. |
There is no clear guidelines as far as I know. I tend to check stars, stack overflow, or Google search results. In any case I personally default to Extras |
Yeah, at least that one seems to be regularly maintained, for now. |
@stevehipwell I suppose you have merge rights now, could you please review this simple age-old PR? |
@rashil2000 please update to the latest version and add a hash capture to |
Sorry I don't know how to put hash in the autoupdate field, could you point me towards an example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see suggestions for the updated version, how to use a different shim name and how to use hashes.
@stevehipwell made the changes, let me know if they're fine |
@stevehipwell Just wanted to ask something. This repo was inactive for a long while (7-8 months), and it seems to have become active again. That said, I've had some CLI tools manifests with me for a while (all of them fit the Main bucket's criteria), I was holding myself from sending any PRs. Should I open a PR for each one of them (8-9 manifests), or a single PR would do? |
There have been a couple of new maintainers added (see #2403). For me I'd strongly prefer a single PR for each tool to keep the commits consistent and tracable. |
Ah, thanks for the heads up! Will do as you say. |
Disk usage analyzer with console interface written in Go
Ref: https://github.com/dodorz/scoop/blob/master/gdu.json