Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdu@5.1.0: Add manifest #2311

Merged
merged 2 commits into from
Sep 10, 2021
Merged

gdu@5.1.0: Add manifest #2311

merged 2 commits into from
Sep 10, 2021

Conversation

rashil2000
Copy link
Member

Disk usage analyzer with console interface written in Go

Ref: https://github.com/dodorz/scoop/blob/master/gdu.json

@rashil2000
Copy link
Member Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gdu

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@telenieko
Copy link
Contributor

telenieko commented Aug 13, 2021

Note that a PR for gdu is already open on ScoopInstaller/Extras#6098
Not submitted to Main because:

Regarding the criteria for inclussion in the main bucket:

I do not think this is a reasonably well-know and/or widely used developer tool. The project is relatively new.

@rashil2000
Copy link
Member Author

How exactly does one measure 'popularity'? If we go by GitHub stars, gdu is more popular than a similar tool called dua (which is already in main bucket), and is just a year younger.

I don't think popularity/age is the problem. This repository is effectively defunct, just look at the amount of trivial open PRs.

@telenieko
Copy link
Contributor

There is no clear guidelines as far as I know.

I tend to check stars, stack overflow, or Google search results.

In any case I personally default to Extras

@rashil2000
Copy link
Member Author

Yeah, at least that one seems to be regularly maintained, for now.

@rashil2000
Copy link
Member Author

@stevehipwell I suppose you have merge rights now, could you please review this simple age-old PR?

@stevehipwell
Copy link
Contributor

@rashil2000 please update to the latest version and add a hash capture to autoupdate. I'll review the installer block after you've made the other changes.

@rashil2000
Copy link
Member Author

Sorry I don't know how to put hash in the autoupdate field, could you point me towards an example?

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggestions for the updated version, how to use a different shim name and how to use hashes.

bucket/gdu.json Outdated Show resolved Hide resolved
bucket/gdu.json Show resolved Hide resolved
@rashil2000
Copy link
Member Author

@stevehipwell made the changes, let me know if they're fine

@stevehipwell stevehipwell merged commit a4b62d0 into ScoopInstaller:master Sep 10, 2021
@rashil2000 rashil2000 deleted the add-gdu branch September 10, 2021 11:03
@rashil2000
Copy link
Member Author

@stevehipwell Just wanted to ask something. This repo was inactive for a long while (7-8 months), and it seems to have become active again. That said, I've had some CLI tools manifests with me for a while (all of them fit the Main bucket's criteria), I was holding myself from sending any PRs. Should I open a PR for each one of them (8-9 manifests), or a single PR would do?

@rashil2000 rashil2000 mentioned this pull request Sep 10, 2021
@stevehipwell
Copy link
Contributor

There have been a couple of new maintainers added (see #2403). For me I'd strongly prefer a single PR for each tool to keep the commits consistent and tracable.

@rashil2000
Copy link
Member Author

Ah, thanks for the heads up!

Will do as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants