-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Use install script instead of original installer #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add closing directive for PRs inside core bucket
@Ash258 I try to add space in dir name, and it pass through If pass through a string to |
Final word on the fullnames. Here is default powershell (windows 10, right) and latest pwsh. Just use |
Yes, for safety, FullName is better. |
What about double quotes? |
I will test lately today with clean W10. Now I will be busy with work stuff for few next hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also adopt new function naming
"version": "3.7.3", | ||
"depends": "dark", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could open discussion if prefixing main bucket requirements is suitable. When i am thinking about this, i do not know how current implementation will handle multiple manifests with same name.
For Examle main/dark
, 'Ash258/dark' If dark is in both buckets, mine will be used (alphabetic order, as far my testing with simple scoop install Wavebox
, Ash258
bucket is preferred over extras
, which contains Wavebox too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref and close: ScoopInstaller/Scoop#3197
close ScoopInstaller/Scoop#2612