Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superfile: Add version 1.1.7.1 #6220

Merged
merged 5 commits into from
Feb 6, 2025
Merged

superfile: Add version 1.1.7.1 #6220

merged 5 commits into from
Feb 6, 2025

Conversation

Aurocosh
Copy link
Contributor

Closes #6191

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

superfile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik
Copy link
Contributor

Guess arm64 version could be added as well.

@aliesbelik aliesbelik mentioned this pull request Dec 12, 2024
Closed
2 tasks
@aviv-julienjehannet
Copy link
Contributor

@Aurocosh can you updte to v1.1.6 hashes can be found in the duplicated ticket (sorry again for that).

@Aurocosh
Copy link
Contributor Author

Version updated to 1.1.6

@aliesbelik
Copy link
Contributor

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

superfile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik mentioned this pull request Jan 30, 2025
Closed
2 tasks
@goostleek
Copy link
Member

goostleek commented Feb 3, 2025 •
edited
Loading

Hi @Aurocosh, Thanks for the PR. I'm sorry I missed it and did the same in #6494. Could you please pick up my changes and apply them to your PR? The changes include the additional homepage property and updated version. I will close my PR then so we can merge yours.

Many thanks for considering my request.

@Aurocosh
Copy link
Contributor Author

Aurocosh commented Feb 4, 2025

Sure, i updated my pull request. Version updated to 1.1.7.1. Homepage url also changed to https://superfile.netlify.app.

@aliesbelik
Copy link
Contributor

/verify

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Your changes do not pass checks.

superfile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

aliesbelik
aliesbelik suggested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Short" form of checkver will only work if GH url already used as homepage, otherwise should be specified explicitly.

bucket/superfile.json Outdated Show resolved Hide resolved
@Aurocosh @aliesbelik
superfile@1.1.7.1: Fixed github checkver source
0d0252d 
Co-authored-by: Aliaksandr Belik <1752374+aliesbelik@users.noreply.github.com>
@Aurocosh
Copy link
Contributor Author

Aurocosh commented Feb 5, 2025

/verify

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

All changes look good.

Wait for review from human collaborators.

superfile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@goostleek goostleek assigned goostleek and unassigned goostleek Feb 6, 2025
@goostleek goostleek self-requested a review February 6, 2025 08:28
@goostleek goostleek requested a review from aliesbelik February 6, 2025 08:28
@goostleek goostleek changed the title superfile: Add version 1.1.4 superfile: Add version 1.1.7.1 Feb 6, 2025
@goostleek goostleek merged commit 37516d1 into ScoopInstaller:master Feb 6, 2025
2 checks passed
@goostleek goostleek mentioned this pull request Feb 6, 2025
Merged
@Aurocosh Aurocosh deleted the superfile branch February 6, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goostleek goostleek goostleek approved these changes

@aliesbelik aliesbelik Awaiting requested review from aliesbelik

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: superfile
4 participants
@Aurocosh @aliesbelik @aviv-julienjehannet @goostleek