Skip to content

Commit

Permalink
fix(buckets): Don't write message OK before bucket is cloned (#4925)
Browse files Browse the repository at this point in the history
  • Loading branch information
chawyehsu authored May 15, 2022
1 parent a2600b1 commit c6fc2de
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Bug Fixes

- **bucket:** Don't check remote URL of non-git buckets ([#4923](https://github.com/ScoopInstaller/Scoop/issues/4923))
- **bucket:** Don't write message OK before bucket is cloned ([#4925](https://github.com/ScoopInstaller/Scoop/issues/4925))

## [v0.2.0](https://github.com/ScoopInstaller/Scoop/compare/v0.1.0...v0.2.0) - 2022-05-10

Expand Down
3 changes: 1 addition & 2 deletions lib/buckets.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,10 @@ function add_bucket($name, $repo) {
error "'$repo' doesn't look like a valid git repository`n`nError given:`n$out"
return 1
}
Write-Host 'OK'

ensure $bucketsdir | Out-Null
$dir = ensure $dir
git_cmd clone "$repo" "`"$dir`"" -q
Write-Host 'OK'
success "The $name bucket was added successfully."
return 0
}
Expand Down

0 comments on commit c6fc2de

Please sign in to comment.