fix(shim): Exit if shim creating failed 'cause no git (#5225)

ScoopInstaller · Oct 28, 2022 · e4f9734 · e4f9734
1 parent 1630e5f
commit e4f9734
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 - **decompress:** Use PS's default 'Expand-Archive()' ([#5185](https://github.com/ScoopInstaller/Scoop/issues/5185))
 - **hash:** Fix SourceForge's hash extraction ([#5189](https://github.com/ScoopInstaller/Scoop/issues/5189))
 - **decompress:** Trim ending '/' ([#5195](https://github.com/ScoopInstaller/Scoop/issues/5195))
+- **shim:** Exit if shim creating failed 'cause no git ([#5225](https://github.com/ScoopInstaller/Scoop/issues/5225))
 - **scoop-import:** Add correct architecture argument ([#5210](https://github.com/ScoopInstaller/Scoop/issues/5210))
 
 ### Code Refactoring

diff --git a/lib/core.ps1 b/lib/core.ps1
@@ -806,6 +806,11 @@ function shim($path, $global, $name, $arg) {
  } else {
  warn_on_overwrite "$shim.cmd" $path
  # find path to Git's bash so that batch scripts can run bash scripts
+ if (!(Get-CommandPath git)) {
+ error "Can't shim '$shim': 'git' is needed but not installed."
+ error "Please install git ('scoop install git') and try again."
+ exit 1
+ }
  $gitdir = (Get-Item (Get-CommandPath git) -ErrorAction:Stop).Directory.Parent
  if ($gitdir.FullName -imatch 'mingw') {
  $gitdir = $gitdir.Parent