Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download functionality refactor #1329

Merged
merged 15 commits into from
Feb 12, 2017
Merged

Download functionality refactor #1329

merged 15 commits into from
Feb 12, 2017

Conversation

deevus
Copy link
Member

@deevus deevus commented Feb 11, 2017 •
edited
Loading

The download output was always rudimentary and I have toyed with the idea of being able to replace the downloader with something like aria2c or axel. Initially I aimed at a general refactor but once I started going I couldn't help but make the download progress a bit nicer

@deevus
Reduce dl_progress nesting to make more readable
1d6c524
@deevus
Refactor dl functions
87c6756 
In the future I want to be able to have different download providers
(aria2c for example) so I'm trying to decouple progress display a bit.

- Removed dl_simple
- Refactored dl_progress; Renamed to dl
- Added dl_progress function
@deevus
Copy link
Member Author

deevus commented Feb 11, 2017 •
edited
Loading 

installing 7zip (16.04)
7z1604-x64.msi [==================================================================] (1.6 MB) 100%
done
checking hash...ok
extracting...done
linking ~\appdata\local\scoop\apps\7zip\current => ~\appdata\local\scoop\apps\7zip\16.04
creating shim for 7z
7zip (16.04) was installed successfully!

@deevus
Copy link
Member Author

deevus commented Feb 11, 2017

Multiple downloads

installing vim (8.0.069)
vim80-069w32.zip [======================================] (1.2 MB) 100%
done
checking hash...ok
extracting...done
vim80-069rt.zip [======================================] (10.3 MB) 100%
done
checking hash...ok
extracting...done
libiconv-1.9.1.bin.woe32.zip [========================] (680.9 KB) 100%
done
checking hash...ok
extracting...done
gettext-runtime-0.13.1.bin.woe32.zip [================] (163.7 KB) 100%
done
checking hash...ok
extracting...done
vimtutor.ps1 [==========================================] (1.0 KB) 100%
done
checking hash...ok
linking ~\appdata\local\scoop\apps\vim\current => ~\appdata\local\scoop\apps\vim\8.0.069
creating shim for vim
creating shim for vimtutor
running post-install script...
~/.vimrc exists, skipping
vim (8.0.069) was installed successfully!

@deevus
Copy link
Member Author

deevus commented Feb 11, 2017

I tried to record a GIF but it didn't turn out well

@deevus
Copy link
Member Author

deevus commented Feb 11, 2017 •
edited
Loading

Possible next steps:

  • Download all urls first, then check hashes, then extract
  • Support another downloader like aria2c that can download multiple urls simultaneously and with multiple connections for improved speeds

@deevus deevus changed the title [WIP] Download functionality refactor Download functionality refactor Feb 11, 2017
r15ch13
r15ch13 approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@r15ch13 r15ch13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks great 😄

Here are your gifs/jifs:
scoop-dl-refactor
scoop-dl-refactor-multi

lukesampson
lukesampson approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@lukesampson lukesampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice!

@deevus
Copy link
Member Author

deevus commented Feb 12, 2017

@r15ch13 Awesome! What did you use to record the GIF? The program I'm using isn't working well since a recent update.

One of those gifs could totally go on the homepage.

@deevus deevus merged commit 6eae06d into master Feb 12, 2017
@deevus deevus deleted the dl-refactor branch February 12, 2017 01:30
@r15ch13
Copy link
Member

r15ch13 commented Feb 12, 2017

I used ScreenToGif. That programm is awesome ❤️

@alvin-nt alvin-nt mentioned this pull request Feb 13, 2017
Closed
@rrelmy rrelmy mentioned this pull request Mar 25, 2017
Closed
@rrelmy rrelmy removed their request for review July 4, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesampson lukesampson lukesampson approved these changes

@r15ch13 r15ch13 r15ch13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deevus @r15ch13 @lukesampson