Download Progress Bar Breaks Download Functionality

[alvin-nt]

Seems like the new download bar is breaking some download. This occurs on stuff that requires fetching resources that do not display its file size. Perhaps related to #1329?

Environment

• Windows 10 64-bit v1607
• PowerShell 5.1

Steps to reproduce

1. Have a clean Windows install
2. Install scoop using the method described in http://scoop.sh/
3. Run scoop install pshazz or scoop install concfg
4. The PS terminal is stuck on infinite loop, trying to produce the 'correct' download bar.

Affected apps

1. pshazz
2. concfg

[rrelmy]

@deevus I can reproduce it, can you take a look at it?

The download URLs for github have a redirect, maybe that's a hint

[deevus]

Will have to wait until later unless someone else can give this a go

…

On Tue, Feb 14, 2017 at 11:47 AM Rémy ***@***.***> wrote: @deevus <https://github.com/deevus> I can reproduce it, can you take a look at it? The download URLs for github have a redirect, maybe that's a hint — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1334 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0QgpVDla3zAsX_hSsvtE4ZpOJeFNl2ks5rcPmOgaJpZM4L_qud> .

[alvin-nt]

Is it currently possible for the user to disable the download bar through scoop config?

[lukesampson]

This looks like it might be a concurrency issue, where for small downloads ContentLength can be read from HttpWebRequest before it has been set, and the default of -1 causes the infinite loop.

As a temporary workaround, I've disabled progress when ContentLength < 0, which should keep installs working until we can address this properly.

To fix it properly, we probably just need to ensure content has been received before reading the ContentLength property. This was a problem with the original code before the new progress bar was added, it just glitched rather than entering an infinite loop.

[deevus]

Thanks Luke. I'll be sure to fix this properly when I get a chance today

…

On Tue, Feb 14, 2017 at 2:03 PM Luke Sampson ***@***.***> wrote: This looks like it might be a concurrency issue, where for small downloads ContentLength can be read from HttpWebRequest before it has been set, and the default of -1 causes the infinite loop. As a temporary workaround, I've disabled progress when ContentLength < 0, which should keep installs working until we can address this properly. To fix it properly, we probably just need to ensure content has been received before reading the ContentLength property. This was a problem with the original code before the new progress bar was added, it just glitched rather than entering an infinite loop. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1334 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0Qgne3v54FCLc4s0KmI1Ce4Q3ouPltks5rcRmagaJpZM4L_qud> .