-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting SCOOP_BRANCH not switch to master #3401
Comments
We should create some Hashtable with defaults which would be used in codebase. $CONFIG_DEFAULT = @{
'SCOOP_BRANCH' = 'master'
'...LESS_MSI' = $false
'aria2' = @{
'split' = 5
}
} So we do not need to duplicate code and could easily change it if needed. Also get_config could return defaults withotu providing it. So instead of L46: |
I like the idea. See discussion before: #3242 (comment) |
- Closes ScoopInstaller#3770 Configuration name is subject of change. I am following dash notation for naming, until config is reworked and united (Relateed ScoopInstaller#3401) Is boolean enough or it is prefered to go with `scoop config 'default-architecture' '32bit|64bit'` which could be more suitable for additional arch support (arm for example) ![A](https://i.imgur.com/RBzEysd.png)
Extracted from #3397
Since SCOOP_BRANCH config is default and created always on installation, it is required for functioning. Since we can't forbid users to delete it we need to adjust it in code.
Should be enough to replace
get_config SCOOP_BRANCH
withget_config SCOOP_BRANCH 'master'
to return default master, when config value do not exists.The text was updated successfully, but these errors were encountered: