Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Add more generic 'Invoke-ExternalCommand' instead of 'run' #3432

Merged
merged 1 commit into from
May 15, 2019
Merged

refactor(core): Add more generic 'Invoke-ExternalCommand' instead of 'run' #3432

merged 1 commit into from
May 15, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 2, 2019

Refactor run in install.ps1

  • Rename to Invoke-ExternalCommand and move to core.ps1
  • Use Invoke-ExternalCommand to refactor Expand-7zipArchive, Expand-MsiArchive, Expand-InnoArchive

TODO in next PR: Refactor Expand-XXXArchive to use an universal interface, just as Get-HelperPath, for further extending.

@Ash258
Copy link
Contributor

Ash258 commented May 2, 2019

I do not see deprecation message for run function Since this function is used inside vcredist packages

@niheaven
Copy link
Member Author

niheaven commented May 2, 2019

Isn't it a pure internal function? 😅

Add backward compatible for run and deprecated warning.

@niheaven
Copy link
Member Author

niheaven commented May 6, 2019

  • Using 'System.Diagnostics.Process' instead of 'Start-Process'
  • Add -RunAs switch for further usage

@niheaven niheaven force-pushed the refactor-run branch 2 times, most recently from 1cf4a9c to b28b363 Compare May 13, 2019 13:08
This was referenced May 13, 2019
Merged
Merged
@niheaven niheaven changed the title refactor(core): install.ps1/run -> core.ps1/Invoke-ExternalCommand refactor(core): Add more generic 'Invoke-ExternalCommand' instead of 'run' May 15, 2019
@r15ch13 r15ch13 merged commit b9deb57 into ScoopInstaller:develop May 15, 2019
@r15ch13 r15ch13 mentioned this pull request May 15, 2019
Closed
@niheaven niheaven deleted the refactor-run branch May 16, 2019 01:56
r15ch13 pushed a commit that referenced this pull request Jun 24, 2019
@niheaven @r15ch13
refactor(core): Add more generic 'Invoke-ExternalCommand' instead of …
61d1c1c 
…'run' (#3432)
@linsui linsui mentioned this pull request Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niheaven @Ash258 @r15ch13