Bucket tests will fail unless you specify helper path

[Ash258]

For bucket tests helpers are not needed at all.

Since f63219f all external buckets test will fail unless you add environment variable for scoop_helpers.

https://ci.appveyor.com/project/Ash258/scoop-ash258/builds/24502846/job/66ps0e8csga27tj5

There should be check if that environment variable exists and if no, just use hardcoded path instead of forcing users to duplicate redundant three lines into own pipeline configuration (As they really do not need them).

[r15ch13]

Like so? test\bin\init.ps1

if ($env:CI_WINDOWS -eq $true) {
    $helpersdir = $env:SCOOP_HELPERS, "C:\projects\helpers" | Where-Object { -not [String]::IsNullOrEmpty($_) } | Select-Object -First 1

    if(!(Test-Path $helpersdir)) {
        New-Item -ItemType Directory -Path $helpersdir
    }
    if(!(Test-Path "$helpersdir\lessmsi\lessmsi.exe")) {
        Start-FileDownload 'https://github.com/activescott/lessmsi/releases/download/v1.6.3/lessmsi-v1.6.3.zip' -FileName "$helpersdir\lessmsi.zip"
        & 7z.exe x "$helpersdir\lessmsi.zip" -o"$helpersdir\lessmsi" -y
    }
    if(!(Test-Path "$helpersdir\innounp\innounp.exe")) {
        Start-FileDownload 'https://raw.githubusercontent.com/ScoopInstaller/Binary/master/innounp/innounp048.rar' -FileName "$helpersdir\innounp.rar"
        & 7z.exe x "$helpersdir\innounp.rar" -o"$helpersdir\innounp" -y
    }
}

[Ash258]

I guess this should work.

I am just tired of adding these lines into all buckets

Ash258/Shovel-Ash258@788260f
shovel-org/Windows-JetBrains-Bucket@659eb1f
Ash258/GenericBucket@1defd6d

I am too lazy to add it into sysinternals bucket too :D

[Ash258]

Fixed in f52b339