Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buckets): Don't write message OK before bucket is cloned #4925

Merged
merged 2 commits into from
May 15, 2022
Merged

fix(buckets): Don't write message OK before bucket is cloned #4925

merged 2 commits into from
May 15, 2022

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented May 15, 2022 •
edited
Loading

Description

Don't write message OK before bucket is cloned

Motivation and Context

Correct the bucket addition message context

How Has This Been Tested?

No critical changes, no need to update tests.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven merged commit c6fc2de into develop May 15, 2022
@niheaven niheaven deleted the chawyehsu-patch-1 branch May 15, 2022 09:18
@niheaven niheaven mentioned this pull request Jun 1, 2022
Merged
@niheaven niheaven mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

@issaclin32 issaclin32 issaclin32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chawyehsu @issaclin32 @rashil2000 @niheaven