Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use proxy if set to none #1806

Closed
wants to merge 1 commit into from
Closed

Do not use proxy if set to none #1806

wants to merge 1 commit into from

Conversation

gitolicious
Copy link
Contributor

No description provided.

@r15ch13
Copy link
Member

r15ch13 commented Nov 2, 2017

Related to #1728?

@gitolicious
Copy link
Contributor Author

Indeed... I missed that one!
After some further investigation, git also doesn't work with the currentuser@default trick. Need to dig deeper and will get back to you.

@gitolicious
Copy link
Contributor Author

Found #1615 to be what I was talking about regarding currentuser@default

@r15ch13
Copy link
Member

r15ch13 commented Nov 2, 2017

lib\config.ps1 is already loaded when lib\git.ps1 is used, so [net.webrequest]::defaultwebproxy should return the correct address + credentials, I guess.
Does something like this work? $proxy = [net.webrequest]::defaultwebproxy

I don't know and don’t use any proxy, so I can't test it.

@chawyehsu
Copy link
Member

@r15ch13 @rasa close this, it's already implemented.

@r15ch13 r15ch13 closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants