Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[buckets] Optimize buckets function #3341

Merged
merged 8 commits into from
Apr 21, 2019
Merged

[buckets] Optimize buckets function #3341

merged 8 commits into from
Apr 21, 2019

Conversation

Ash258
Copy link
Contributor

@Ash258 Ash258 commented Apr 19, 2019

  • Use Verb-Noun naming

Keep buckets function for compatibility if someone use it inside manifests.

r15ch13
r15ch13 reviewed Apr 21, 2019
View reviewed changes
@Ash258
Fix casing
d6c700b 
Co-Authored-By: Ash258 <cabera.jakub@gmail.com>
@Ash258
Copy link
Contributor Author

Ash258 commented Apr 21, 2019

Maybe this look better than one line?

image

@r15ch13
Copy link
Member

r15ch13 commented Apr 21, 2019

Add WARN to make it the same as warn() and indent it.

image

@Ash258
Copy link
Contributor Author

Ash258 commented Apr 21, 2019

Done. Used warn function directly for proper reference counter, when will warn function be refactored

image

@Ash258 Ash258 mentioned this pull request Apr 21, 2019
Merged
@r15ch13 r15ch13 merged commit 4463514 into ScoopInstaller:master Apr 21, 2019
@Ash258 Ash258 deleted the buckets_function branch April 21, 2019 11:02
@niheaven niheaven mentioned this pull request Apr 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r15ch13 r15ch13 r15ch13 left review comments

@rasa rasa rasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ash258 @r15ch13 @rasa