Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(schema): Add explicit escape to opening bracket matcher in jp/jsonpath regex #3719

Merged
merged 4 commits into from
Jan 8, 2022

Conversation

ParkerM
Copy link
Contributor

@ParkerM ParkerM commented Oct 28, 2019

This PR adds an explicit escape to the opening bracket matcher for the "jp"|"jsonpath" properties in the JSON schema.
This resolves the following issue with manifest validation in IntelliJ IDEA:
image

There were 4 instances of this pattern in the schema, so they were extracted to a sub-schema at #/definitions/jsonPathPattern.

@Ash258
Copy link
Contributor

Ash258 commented Oct 28, 2019

Rebase to develop

@ParkerM ParkerM changed the base branch from master to develop October 28, 2019 22:19
@ParkerM
Copy link
Contributor Author

ParkerM commented Oct 28, 2019

Whoops, sorry about that! Base changed to develop.

Ash258
Ash258 previously approved these changes Nov 8, 2019
rashil2000
rashil2000 previously approved these changes Jan 8, 2022
@niheaven niheaven dismissed stale reviews from rashil2000 and Ash258 via fadcbee January 8, 2022 12:05
@niheaven niheaven changed the title json schema: Add explicit escape to opening bracket matcher in jp/jsonpath regex build(schema): Add explicit escape to opening bracket matcher in jp/jsonpath regex Jan 8, 2022
@niheaven niheaven merged commit 92c89f8 into ScoopInstaller:develop Jan 8, 2022
@ParkerM ParkerM deleted the schema-jsonpath-pattern branch January 9, 2022 23:50
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants