Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): doc: Update PR checklist #4851

Merged
merged 2 commits into from
Mar 31, 2022
Merged

(chore): doc: Update PR checklist #4851

merged 2 commits into from
Mar 31, 2022

Conversation

rashil2000
Copy link
Member

Description

People always keep forgetting that the PR needs to be raised against the develop branch, instead of master.

Also, they need to update the changelog.

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven niheaven merged commit 55b26da into develop Mar 31, 2022
@niheaven niheaven deleted the rashil2000-patch-1 branch March 31, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashil2000 @niheaven