Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): set Webclient encoding to UTF-8 #4912

Closed
wants to merge 1 commit into from

Conversation

yi-Xu-0100
Copy link
Contributor

@yi-Xu-0100 yi-Xu-0100 commented May 9, 2022

Description

Motivation and Context

Closes #4911

How Has This Been Tested?

when these settings are applied, the download with example link https://raw.githubusercontent.com/ygguorun/scoop-bucket/master/bucket/PDFPatcher.json will work well.

图片

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@rashil2000
Copy link
Member

Please target the develop branch.

We might need to do this in 'bin/checkver.ps1' too (see #4324)

@yi-Xu-0100 yi-Xu-0100 closed this May 28, 2022
@yi-Xu-0100
Copy link
Contributor Author

Superceded by #4956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Can not install with url encoded in utf-8
2 participants