Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builds(checkver): Exit routine earlier if error #5025

Merged
merged 3 commits into from
Jul 1, 2022
Merged

builds(checkver): Exit routine earlier if error #5025

merged 3 commits into from
Jul 1, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jul 1, 2022 •
edited
Loading

Description

If there is error, continue to next app earlier and not parse a empty page.

Motivation and Context

How Has This Been Tested?

Before:
image

After:
image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

rashil2000
rashil2000 previously approved these changes Jul 1, 2022
View reviewed changes
@niheaven niheaven merged commit 794f8a5 into develop Jul 1, 2022
@niheaven niheaven deleted the fix-checkver branch July 1, 2022 14:22
@niheaven niheaven mentioned this pull request Jul 2, 2022
Merged
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
@niheaven @slaughtering
builds(checkver): Exit routine earlier if error (ScoopInstaller#5025)
699d8d7
@niheaven niheaven mentioned this pull request Aug 4, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000