Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): Move from cache when --no-cache #5039

Merged
merged 3 commits into from
Jul 16, 2022
Merged

fix(install): Move from cache when --no-cache #5039

merged 3 commits into from
Jul 16, 2022

Conversation

rashil2000
Copy link
Member

Description

When the --no-cache flag is specified, the downloaded file should be moved from the cache folder, instead of copying it.

This was being done in dl_with_cache_aria2 function, but not in dl_with_cache function.

This PR fixes it.

Motivation and Context

Closes #5038

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@rashil2000 rashil2000 merged commit 9e2e252 into develop Jul 16, 2022
@rashil2000 rashil2000 deleted the cache-fix branch July 16, 2022 04:29
@niheaven niheaven mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rashil2000