Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iec): Rename 'Invoke-ExternalCommand()' to 'Start-ExternalProcess()' and support EnvVars/WorkingDirectory #5124

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Aug 25, 2022

Description

  • Rename Invoke-ExternalCommand() to Start-ExternalProcess()
  • Add environment variables and working directory suport

Motivation and Context

How Has This Been Tested?

image

With proxy server on and off.

For the strange git ls-remotes output: git print From https://github.com/ScoopInstaller/Tests via the error output 🤣

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

lib/core.ps1 Outdated Show resolved Hide resolved
lib/core.ps1 Outdated Show resolved Hide resolved
@niheaven niheaven changed the title feat(iec): Support EnvVars in 'Invoke-ExternalCommand()' feat(iec): Support EnvVars and WorkingDirectory in 'Start-ExternalProcess()' (a.k.a. 'Invoke-ExternalCommand()') Sep 9, 2022
@niheaven niheaven changed the title feat(iec): Support EnvVars and WorkingDirectory in 'Start-ExternalProcess()' (a.k.a. 'Invoke-ExternalCommand()') refactor(iec): Support EnvVars and WorkingDirectory in 'Start-ExternalProcess()' (a.k.a. 'Invoke-ExternalCommand()') Nov 7, 2023
@niheaven niheaven changed the title refactor(iec): Support EnvVars and WorkingDirectory in 'Start-ExternalProcess()' (a.k.a. 'Invoke-ExternalCommand()') refactor(iec): Rename 'Invoke-ExternalCommand()' to 'Start-ExternalProcess()' and support EnvVars/WorkingDirectory Nov 7, 2023
- refactor(iec): Rename some parameters
- feat(iec): Support EnvVars in 'Invoke-ExternalCommand()'
- fix(iec): Redirect output when 'CreateNoWindow'
- fix(iec): Allow empty 'ArgumentList'
- feat(iec): Support 'WorkingDirectory'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants