Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkurls): Allow checking URLs from private_hosts #5151

Closed
wants to merge 1 commit into from
Closed

feat(checkurls): Allow checking URLs from private_hosts #5151

wants to merge 1 commit into from

Conversation

cesarcoatl
Copy link

Description

Similar to #4254 but for .\bin\checkurls.ps1.

Motivation and Context

Closes #5150

How Has This Been Tested?

I have made the changes locally and ran the command successfully.

Before:

$ .\bin\checkurls.ps1
[U]RLs
 | [O]kay
 |  | [F]ailed
 |  |  |
[1][0][1] ignition
       > The remote server returned an error: (403) Forbidden. (https://files.inductiveautomation.com/release/ia/8.1.20/20220823-1339/Ignition-windows-x86-64-8.1.20.zip)
[1][1][0] jython

After:

$ .\bin\checkurls.ps1
[U]RLs
 | [O]kay
 |  | [F]ailed
 |  |  |
[1][1][0] ignition
[1][1][0] jython

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@cesarcoatl cesarcoatl changed the title feat(bin): allow checking URLs from private_hosts feat(checkursl): allow checking URLs from private_hosts Sep 15, 2022
@cesarcoatl cesarcoatl changed the title feat(checkursl): allow checking URLs from private_hosts feat(checkurls): allow checking URLs from private_hosts Sep 15, 2022
@cesarcoatl cesarcoatl changed the title feat(checkurls): allow checking URLs from private_hosts feat(checkurls): Allow checking URLs from private_hosts Sep 15, 2022
@rashil2000
Copy link
Member

Can you update the changelog too? Thanks.

@cesarcoatl
Copy link
Author

I created my fork just with the master branch. Is it OK if we close this PR and I open a new one based on the develop branch?

That way the CHANGELOG will generate appropriately.

@cesarcoatl cesarcoatl closed this Sep 15, 2022
@cesarcoatl cesarcoatl deleted the feat/bin/checkurls-private_hosts branch September 15, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants