-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(install): Add support for ARM64 architecture #5154
Conversation
Stuff remaining:
Food for thought: Should we compile and add different shim binaries for different architectures? That is, |
7zip ships an MSI installer for x86 and x64 archs, but only a self-extracting executable for ARM64. We would need to request ipavlov to provide an MSI installer which Scoop can use in the 7zip manifest. See https://sourceforge.net/p/sevenzip/support-requests/431. |
- Move `default_architecture()` to `core.ps1`
Make some changes:
Testing manifests are pushed to |
@rashil2000 I've test it and LGTM, any comments? |
* Initial support for ARMv8 * Add fallback mechanism * Update changelog * Update useragent * Some typo and format changes * Use `env:ProgramFiles(Arm)` to detect ARM64 - Move `default_architecture()` to `core.ps1` * Rename 'ensure_architecture()' and 'default_architecture()' * Refactor 'supports_architecture()' to 'Get-SupportedArchitecture()' Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Description
Enables installing ARMv8 apps
Motivation and Context
Closes #3146
Supercedes #4071
How Has This Been Tested?
First fzf is from main bucket. Second fzf is a modified version, as follows:
Checklist:
develop
branch.