Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds(checkver): Support XML default namespace #5191

Merged
merged 2 commits into from
Oct 15, 2022
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Oct 14, 2022

Description

If XML has default namespace such as <xxx xmlns="xxxx">, it could not be added again via System.Xml.XmlNamespaceManager.AddNamespace(), so add it with ns and add ns: to XPath.

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title builds(xml): Support default namespace builds(checkver): Support XML default namespace Oct 15, 2022
@niheaven
Copy link
Member Author

@se35710 So could be merged?

@niheaven niheaven merged commit 9fda542 into develop Oct 15, 2022
@niheaven niheaven deleted the fix-checkver branch October 15, 2022 12:17
github-actions bot pushed a commit to pukkandan/Scoop that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants