-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(unix): Remove unix.ps1 #5235
Conversation
Not a fan of this, we changed it to ~/scoop and resolved the long path issue in 2016. No reason to revert it back to break things again. edit: |
Then change the special folder to PS, does the long path issue still existed? And is it the same one as #4327? |
I've updated summaries table, have all locations. So keep it as is? @ScoopInstaller/maintainers |
I'm in favor of this location as well (I don't like polluting my user home folder, and besides, LocalAppData is the recommended location for installing apps), but this is a HUGE breaking change, so I'm not sure if we should do this. We should capitalize the Also, we need to change backslashes to forward slashes, otherwise Scoop will remain incompatible on Unix. |
Also @niheaven, did you update the branch protection rules for buckets? The excavator action is failing in Main bucket. |
Yes,I forgot excavator's permission😅 Now protection rules are disabled. |
PowerShell uses backslashes even on Unix, and can coerce them easily. The only exception is .NET, which only recognizes slashes on Unix. But a good news here is .NET could use slashes on Windows too. Please refer to Pester 5 test files (Import-Bucket-Tests and Manifest.Tests), they are both passed on Ubuntu and macOS. After this PR, Unix supports is ready again, at least for developers. Install Scoop normally, or git clone the repo and set $env:SCOOP_HOME/$env:SCOOP_CACHE to correct location, then all "bin" files should by used, such as downloading and update version. |
If this is what you believe in a professional way, then you should not use Scoop to manage apps. Scoop does not always follow Windows conventions in design, it provides a *nix user interface while its internal implementation evolves. The codebase still uses the architecture of If this is what you believe in a professional way, I assume that you want to challenge the core philosophy of Scoop. Scoop puts apps' data to a
|
Hmm, I think @rashil2000's professional way is Scoop, the first capital letter? I've changed back to |
Jeez @chawyehsu, I was talking about the capital 'S' when I said professional. I'm actually against the location change (see my comment above). |
I'm sorry for the misunderstanding. But I still stand for the point I told: there shouldn't be a judgment of what's more professional in this case. Why would Further, I would use the phrase Like |
I'll merge it since nobody would review it 😥 |
I would leave All the other changes are fine. |
That's right, on Linux/macOS lower capital such as So change back to |
Description
Uniform paths on Windows and Linux/macOS, and remove unused
unix.ps1
.Scoop's default folder is under
UserProfile
(C:\Users\<user>
on Windows,/home/<user>
on Linux/macOS), and global folder is underCommonApplicationData
(C:\ProgramData
on Windows,/usr/share
on Linux/macOS).Summaries:
UserProfile
)LocalApplicationData
)C:\Users\<user>\scoop
C:\Users\<user>\AppData\Local\scoop
C:\ProgramData\scoop
/home/<user>/scoop
/home/<user>/.local/share/scoop
/usr/share/scoop
RFC
As said in https://learn.microsoft.com/en-us/dotnet/api/system.environment.specialfolder?view=netframework-4.5,
UserProfile
shouldn't be used to store apps and/or data.But scoop has changed its root folder from
LocalApplicationData
toUserProfile
in fc54b2f to fix #737, there may not be sufficient reason to change back.Motivation and Context
Simplify code base and development on Linux/macOS platform.
How Has This Been Tested?
There aren't tests for these config.
Checklist:
develop
branch.