Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bucket): Switch nirsoft bucket to ScoopInstaller/Nirsoft #5328

Merged
merged 5 commits into from
Mar 11, 2023

Conversation

rasa
Copy link
Member

@rasa rasa commented Jan 7, 2023

Per #5293

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@rasa
Copy link
Member Author

rasa commented Jan 7, 2023

@ScoopInstaller/maintainers : Should we instead create a "nirsoft2" bucket to allow users to "upgrade" to the new bucket when they're ready?

@rashil2000
Copy link
Member

@ScoopInstaller/maintainers : Should we instead create a "nirsoft2" bucket to allow users to "upgrade" to the new bucket when they're ready?

I don't think that should be necessary.

However, I would like to stress again on the fact that we need more bucket maintainers, since more and more buckets are getting moved into the ScoopInstaller org. Should we make a community call for Nirsoft bucket, preferably before this PR is actually merged?

@rasa rasa marked this pull request as ready for review February 20, 2023 19:22
niheaven
niheaven previously approved these changes Mar 10, 2023
niheaven
niheaven previously approved these changes Mar 10, 2023
@niheaven niheaven changed the title Switch nirsoft bucket to ScoopInstaller/Nirsoft feat(bucket): Switch nirsoft bucket to ScoopInstaller/Nirsoft Mar 10, 2023
@niheaven niheaven merged commit ad0f617 into develop Mar 11, 2023
@niheaven niheaven deleted the rasa-update-nirsoft-bucket branch March 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants