-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Avoid error messages when deleting non-existent environment variable #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HUMORCE
commented
Jun 19, 2023
@@ -698,7 +698,7 @@ function env($name, $global, $val = '__get') { | |||
$RegistryValueOption = [Microsoft.Win32.RegistryValueOptions]::DoNotExpandEnvironmentNames | |||
$EnvRegisterKey.GetValue($name, $null, $RegistryValueOption) | |||
} elseif ($val -eq $null) { | |||
$EnvRegisterKey.DeleteValue($name) | |||
try { $EnvRegisterKey.DeleteValue($name) } catch { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operation of adding, deleting environment variable both no output, so a empty catch block here.
HUMORCE
changed the title
fix(core): Check if the envrionment variable exists before deletion
fix(core): Avoid error messages when deleting non-existent environment variable
Jun 19, 2023
niheaven
previously approved these changes
Jun 29, 2023
CrendKing
pushed a commit
to CrendKing/Scoop
that referenced
this pull request
Oct 3, 2023
…t variable (ScoopInstaller#5547) * fix(core): Check if the envrionment variable exists before delete * CHANGELOG * Use `try, catch`, value of env variable may is null/empty * UPDATE CHANGELOG * Brackets --------- Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Issue:
When delete environment variable during uninstallation, if the environment variable has been deleted before, we will get a error message.
Examples:
How Has This Been Tested?
Before:
After:
Checklist:
develop
branch.