Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(decompress): Remove unused parent dir w/ 'extract_dir' #5682

Merged
merged 5 commits into from
Mar 13, 2024
Merged

fix(decompress): Remove unused parent dir w/ 'extract_dir' #5682

merged 5 commits into from
Mar 13, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Oct 9, 2023 •
edited
Loading

Description

Remove unused directory if extract_dir is nested.

Motivation and Context

In current extraction function, if extract_dir is nested, e.g. aa\bb, the aa dir is left after installation. This will fix it.

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven marked this pull request as ready for review March 12, 2024 15:36
@niheaven niheaven merged commit 9d07c33 into develop Mar 13, 2024
2 checks passed
@niheaven niheaven deleted the fix-extract_dir branch March 13, 2024 10:41
@niheaven niheaven mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niheaven