fix(core): Search for Git executable instead of any cmdlet #5998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5979
Motivation and Context
Before this commit, if a user had a custom alias or function for
git
specified in their PowerShell profile,Get-HelperPath
would return path to the PowerShell module where the function is defined instead of path to the actual Git binary.How Has This Been Tested?
Tested interactively, the code seems reasonably obvious to me. To test the fix, run the following snippet:
Without this PR, the invocation results in the folowing error:
Checklist:
develop
branch.