Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goneovim-nightly: Fix version #618

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

shiena
Copy link
Contributor

@shiena shiena commented Aug 21, 2022

The current version is not in ascending order so scoop update will not detect the update. Therefore, replace it with the update date.

@shiena
Copy link
Contributor Author

shiena commented Aug 28, 2022

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

goneovim-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@shiena
Copy link
Contributor Author

shiena commented Aug 29, 2022

Here's why the checkver failed:
ScoopInstaller/Scoop#5129

@tech189
Copy link
Member

tech189 commented Sep 3, 2022

Nice find, shall we wait for a fix in Scoop or should we make a temporary regex that will match M/d/yyyy h:m:s tt (assuming all GitHub actions runners use en-US locale)? @issaclin32

@issaclin32
Copy link
Member

@tech189 I think we should make a temporary regex fix first, so that we can fix it as sooner.

@shiena
Copy link
Contributor Author

shiena commented Sep 4, 2022

I think a temporary regex is a good idea. However, in the M/d/yyyy h:m:s format, I don't know a good way to zero-fill the single-digit month and day and extract the two-digit month and day as they are.
For example, 9/4/2020 converts to 20200904 and 11/23/2020 converts to 20201123.

@tech189
Copy link
Member

tech189 commented Sep 4, 2022

As a workaround for having to make a regex for the en-US datetime, I just moved the updated_at selection from jsonpath into the regex, should work now.

@tech189
Copy link
Member

tech189 commented Sep 4, 2022

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

All changes look good.

Wait for review from human collaborators.

goneovim-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@shiena
Copy link
Contributor Author

shiena commented Sep 4, 2022

@tech189 Great and thank you. This method was a blind spot.

@tech189 tech189 merged commit 5beb9c1 into ScoopInstaller:master Sep 4, 2022
@shiena shiena deleted the fix/goneovim-nightly branch September 4, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants