Fix H-01: Allow whitelisted accounts below threshold to propose #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferas
requested changes
Dec 16, 2024
contracts/CompoundGovernor.sol
Outdated
| @@ -135,32 +135,74 @@ contract CompoundGovernor is | |||
| return GovernorSequentialProposalIdUpgradeable.hashProposal(_targets, _values, _calldatas, _descriptionHash); | |||
| } | |||
|
|
|||
| /// @notice Creates a new proposal. | |||
| /// @dev This is an override of the function that skips proposal threshold check for whitelisted accounts. | |||
There was a problem hiding this comment.
this sounds like it's referring to some other function (in GovernorUpgradeable) that skips the proposal threshold check. but in fact, THIS is the function doing that.
i think i'd recommend expanding the @notice to include details on how the whitelisting works as well, otherwise that'll be undocumented afaik
There was a problem hiding this comment.
Updated in: f6bb8a8 and added to the whitelisting related docs above setWhitelistAccountExpiration.
| @@ -74,6 +74,15 @@ contract Propose is CompoundGovernorTest { | |||
| vm.assertEq(uint8(governor.state(_proposalId)), uint8(IGovernor.ProposalState.Active)); | |||
| } | |||
|
|
|||
| function test_AWhitelistedAccountCanProposeWhileBelowThreshold(address _proposer) public { | |||
There was a problem hiding this comment.
Suggested change
| function test_AWhitelistedAccountCanProposeWhileBelowThreshold(address _proposer) public { | |
| function test_WhitelistedAccountCanProposeBelowThreshold(address _proposer) public { |
| @@ -93,6 +102,21 @@ contract Propose is CompoundGovernorTest { | |||
| ); | |||
| _submitProposal(_proposer, _proposal); | |||
| } | |||
|
|
|||
| function test_RevertIf_ProposerIsBelowThreshold(address _proposer) public { | |||
There was a problem hiding this comment.
Suggested change
| function test_RevertIf_ProposerIsBelowThreshold(address _proposer) public { | |
| function test_RevertIf_NonWhitelistedProposerIsBelowThreshold(address _proposer) public { |
| @@ -93,6 +102,21 @@ contract Propose is CompoundGovernorTest { | |||
| ); | |||
| _submitProposal(_proposer, _proposal); | |||
| } | |||
|
|
|||
| function test_RevertIf_ProposerIsBelowThreshold(address _proposer) public { | |||
There was a problem hiding this comment.
could also use a... test_RevertIf_ExpiredWhitelistedAccountIsBelowThreshold just to make sure we're covering the breadth of the feature
wildmolasses
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #77