Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial version of ERC6538Registry and tests #3

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

mds1
Copy link
Collaborator

@mds1 mds1 commented Jul 19, 2023

Adds a first implementation of the ERC-6538 Registry contract. It does not yet implement the registerKeysOnBehalf methods, which will be done in a future PR.

@mds1
Copy link
Collaborator Author

mds1 commented Jul 19, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mds1 mds1 changed the title feat: add initial version of ERC6538Registry and tests" feat: add initial version of ERC6538Registry and tests Jul 19, 2023
Copy link

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a couple questions on validation

src/ERC6538Registry.sol Show resolved Hide resolved
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small initial comments @mds1 but looking good!

src/interfaces/IERC6538Registry.sol Outdated Show resolved Hide resolved
src/interfaces/IERC6538Registry.sol Outdated Show resolved Hide resolved
@mds1
Copy link
Collaborator Author

mds1 commented Jul 20, 2023

@mds1 started a stack merge that includes this pull request via Graphite.

@mds1 mds1 changed the base branch from feat/ERC5564Announcer to main July 20, 2023 23:39
@mds1
Copy link
Collaborator Author

mds1 commented Jul 20, 2023

Graphite rebased this pull request as part of a merge.

@github-actions
Copy link

Coverage after merging feat/ERC6538Registry into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ERC5564Announcer.sol100%100%100%100%
   ERC6538Registry.sol100%100%100%100%

@mds1 mds1 merged commit 145d7f2 into main Jul 20, 2023
5 checks passed
@mds1
Copy link
Collaborator Author

mds1 commented Jul 20, 2023

@mds1 merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants