Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect wallet button #227

Merged
merged 7 commits into from
Sep 17, 2021

Conversation

radchukd
Copy link
Contributor

@radchukd radchukd commented Sep 6, 2021

I fixed wallet loading and added the "Connect a wallet" button along with some refactoring.

@apbendi apbendi requested a review from mds1 September 7, 2021 11:29
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radchukd, looking good! Nice work.

One thing I did notice is clicking on my address after connecting, which used to allow the user to change wallets, now produces an error:

Screen Shot 2021-09-07 at 7 28 21 AM

Screen Shot 2021-09-07 at 7 28 35 AM

frontend/src/store/wallet.ts Outdated Show resolved Hide resolved
frontend/src/store/wallet.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @radchukd!

@apbendi I'll wait for your final review before merging

@apbendi apbendi merged commit 52f577a into ScopeLift:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants