Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ethers.js version #490

Merged
merged 3 commits into from
Apr 18, 2023
Merged

chore: bump ethers.js version #490

merged 3 commits into from
Apr 18, 2023

Conversation

mds1
Copy link
Collaborator

@mds1 mds1 commented Apr 14, 2023

Enables support for ENS names with emojis, ref ethers-io/ethers.js#2376

enables support for ENS names with emojis, ref ethers-io/ethers.js#2376
@mds1 mds1 requested a review from apbendi April 14, 2023 17:34
@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit b4ddccc
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/643e489cb174880008fa83e2
😎 Deploy Preview https://deploy-preview-490--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Coverage after merging chore/bump-ethers into master will be

85.97%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%85
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts74.58%100%58.33%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts85.71%86.67%66.67%87.50%11, 26, 46, 50, 8
   Umbra.ts79.77%74.19%76%83.66%134–135, 211–212, 212–213, 222–223, 241, 287–290, 352, 360, 360–362, 364, 366, 386, 386, 386–387, 392–393, 396, 399, 415, 432–433, 481, 515, 532, 545–546, 556–557, 580–581, 657, 660, 660, 660, 663, 670, 670, 677, 681, 681, 681–682, 695, 699, 702–703, 709–711, 718, 718, 718–721
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts81.29%73.33%86.67%86.29%107–109, 111–113, 119, 137–138, 185, 238, 264, 266–267, 276, 276, 276–277, 279, 282, 291–292, 336, 336, 336, 356, 385, 387, 392, 404, 404, 410, 412–413, 424–428, 434, 436, 478–479, 479, 479–481, 481, 481, 57–58, 581, 586, 83, 91, 91
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apbendi apbendi merged commit 2eafdfb into master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants