The Everything Update (UI Overhaul + Bug Fixes) #30

speecil · 2024-10-23T23:02:37Z

no longer uses the base game leaderboard
uses leaderboard core
fixed profile pictures
fixed cell clicking
added map info modal
added map link button to leaderboard
added ranking status header below panelview (coloured header that shows ranked status like stars)
added country rank to the panelview
fixed replay playback inconsistencies
removed old unity imgui replay ui
new screen space replay ui on desktop (with timebar scrubber)
fixed legacy replay method error
added setting to hide replay watermark if you are the user in the replay

I have probably forgotten something...

Qwasyx

Finally got to review this. See the comments for details.

README.md

ScoreSaber/Core/Data/Internal/Settings.cs

ScoreSaber/Core/Data/Models/ScoreSaberTeam.cs

ScoreSaber/Core/ReplaySystem/Accessors.cs

ScoreSaber/UI/Leaderboard/ScoreSaberLeaderboardViewController.cs

ScoreSaber/UI/Main/ViewControllers/TeamViewController.cs

ScoreSaber/UI/PromoBanner/PromoBannerView.cs

ScoreSaber/Core/AffinityPatches/MenuPresencePatches.cs

ScoreSaber/Core/Data/Models/LeaderboardUploadData.cs

ScoreSaber/Core/Data/Models/ScoreSaberTeam.cs

Qwasyx · 2024-12-11T17:59:31Z

ScoreSaber/Core/ReplaySystem/Playback/ReplayTimeSyncController.cs

            }

-            return currentNode;
+            _lastLocatedNode = _beatmapData.allBeatmapDataItems.Find(_beatmapDataItemsCache[Math.Max(0, high)]);


sorry to disappoint you, but this operation alone is O(n), completely making your binary search useless. You need to cache the actual LinkedList nodes, not just their content (please verify that those are actually consistent, i.e. can be cached).

Furthermore it is not consistent with your old code. Your old code returned null if you scrolled to the start of the map.

ScoreSaber/Core/Services/ScoreSaberRichPresenceService.cs

ScoreSaber/UI/Elements/Leaderboard/MapInfoView.cs

ScoreSaber/UI/Elements/Profile/ProfileDetailView.cs

ScoreSaber/UI/Leaderboard/ScoreSaberLeaderboardViewController.cs

Umbranoxio · 2024-12-14T03:49:51Z

ScoreSaber/Core/AffinityPatches/MenuPresencePatches.cs

+                gameMode = Services.GameMode.practice;
+
+                // this is to privatise the practice mode song, as it would be exposed in the rich presence, still not shown in UI though.
+                var songeventPrivate = new SongRichPresenceInfo(_richPresenceService.TimeRightNow, gameMode,


Nitpick but, songEventPrivate

Umbranoxio · 2024-12-14T03:50:03Z

ScoreSaber/Core/AffinityPatches/MenuPresencePatches.cs

+                startTime = (int)__instance._practiceViewController._practiceSettings.startSongTime;
+            }
+
+            var songevent = CreateSongStartEvent(__instance.selectedBeatmapLevel, __instance.selectedBeatmapKey, gameplayModifiers, startTime, gameMode);


Same as above

Umbranoxio · 2024-12-14T03:58:07Z

ScoreSaber/Core/Services/LeaderboardService.cs

@@ -16,20 +18,25 @@ public LeaderboardService() {
            Plugin.Log.Debug("LeaderboardService Setup");
        }

-        public async Task<LeaderboardMap> GetLeaderboardData(int maxMultipliedScore, BeatmapLevel beatmapLevel, BeatmapKey beatmapKey, PlatformLeaderboardsModel.ScoresScope scope, int page, PlayerSpecificSettings playerSpecificSettings, bool filterAroundCountry = false) {
+        public async Task<LeaderboardMap> GetLeaderboardData(int maxMultipliedScore, BeatmapLevel beatmapLevel, BeatmapKey beatmapKey, ScoreSaber.UI.Leaderboard.ScoreSaberLeaderboardViewController.ScoreSaberScoresScope scope, int page, PlayerSpecificSettings playerSpecificSettings) {


We've imported ScoreSaber.UI.Leaderboard above, why are we accessing it the long way here.

Umbranoxio · 2024-12-14T04:13:41Z

ScoreSaber/Core/Services/ScoreSaberRichPresenceService.cs

+
+            try {
+                var socketOptions = new Socket.Options(new JsonMessageSerializer());
+                var socketAddress = "wss://ssrt.bzaz.au/socket"; // change to scoresaber subdomain once ready.


wss://realtime.scoresaber.com/socket

Should be a constant defined outside of the method, should build off of the baseUrl defined Plugin.cs however this was implemented

i made it a constant within the file, building off of the baseUrl would be difficult because its the api url, where this is the socket

The baseUrl should look like scoresaber.com, everything else should build off of this base.

implemented

Wouldn't it make more sense to have not a single baseUrl, but instead multiple baseUrls for the different parts (still all stored at the same spot). That way it would be much easier to test individual component changes locally without having to deploy a full blown backend with all parts/components each time.

Umbranoxio · 2024-12-14T04:19:26Z

ScoreSaber/Core/Services/ScoreSaberRichPresenceService.cs

Create a new namespace and folder for this. Organize it properly e.g: models go in a Models folder, and classes should be in separate files and well-structured. The current setup isn’t scalable since our realtime functionality will expand beyond live presence in the future.

Umbranoxio · 2024-12-14T04:20:51Z

ScoreSaber/Core/Services/TweeningService.cs

Services usually refer to ScoreSaber communicating with an external source or larger functionality, while I'm not happy with our current structure and it does need refactoring, this is a UI utility.

Made it TweeningUtils

Umbranoxio · 2024-12-14T04:25:50Z

ScoreSaber/UI/Elements/Profile/ProfileDetailView.cs

+                    mapPresence.gameObject.SetActive(true);
+                    mapPresenceTitle.gameObject.SetActive(true);
+                    mapImagePresence.SetImageAsync($"https://cdn.scoresaber.com/covers/{_richPresence.state.currentMap.Hash}.png").RunTask();
+                }


Build this url from a constant baseUrl

Umbranoxio · 2024-12-14T04:33:33Z

ScoreSaber/UI/Elements/Profile/ProfileDetailView.cs

+                Plugin.Log.Error($"BeatmapDownloader is null, install a mod to [APP] that injects IScoreSaberBeatmapDownloader");
+            }
+            // load sprites
+            UnityMainThreadTaskScheduler.Factory.StartNew(() => BeatSaberMarkupLanguage.Utilities.LoadSpriteFromAssemblyAsync("ScoreSaber.Resources.Online.png")).ContinueWith(x => { _onlineSprite = x.Result.Result; });


We reference these strings quite frequently (later on in the file too). We should have one source of truth for them.

Made constants

Umbranoxio · 2024-12-14T04:37:57Z

ScoreSaber/UI/Leaderboard/ScoreSaberLeaderboardViewController.cs

+
+        [UIAction("OpenLeaderboardPage")]
+        internal void OpenLeaderboardPage() {
+            Application.OpenURL($"https://scoresaber.com/leaderboard/{_leaderboardService.currentLoadedLeaderboard.leaderboardInfoMap.leaderboardInfo.id}");


Build from BaseURL

Umbranoxio · 2024-12-14T04:38:25Z

ScoreSaber/UI/Leaderboard/ScoreSaberLeaderboardViewController.cs

+                _panelView.statusWasSelected = delegate () {
+                    if (_leaderboardService.currentLoadedLeaderboard == null) { return; }
+                    _parserParams.EmitEvent("close-modals");
+                    Application.OpenURL($"https://scoresaber.com/leaderboard/{_leaderboardService.currentLoadedLeaderboard.leaderboardInfoMap.leaderboardInfo.id}");


Build from BaseURL

Umbranoxio · 2024-12-14T04:40:27Z

ScoreSaber/UI/Leaderboard/ScoreSaberLeaderboardViewController.cs

+
+            UnityMainThreadTaskScheduler.Factory.StartNew(async () => {
+                if (!Plugin.Settings.hasAcceptedRichPresenceDisclaimer) {
+                    await Task.Delay(500);


Do we have a runtime issue if this delay doesn't exist or is it purely for UX? If it's for UX, this is fine. But if we're avoiding a runtime issue this isn't a stable fix and should be addressed correctly.

without the delay, the modal doesnt have the foreground effect for some reason. Im not sure why

All it needs is a single millisecond after some testing

This implies that we're needing to wait a frame. Try await Task.Yield(); instead.

Or, use a coroutine which begins with yield return null; to wait until the next frame before ShowRichPresenceDisclaimer()

speecil and others added 30 commits October 13, 2024 22:04

begin moving scoresaber to leaderboardcore

0d16bca

More stuff i forgot, not working

f59914c

Closer, but bsml macros are laughing at me

b4caac8

somewhere

b5c2569

Fixed Page

fbcc9d4

Merge remote-tracking branch 'upstream/main'

7722966

Showing scores now, still buggy

1479e6b

VERY WORKING STATE

ef71707

Cache leaderboardInfoMaps and fade cell text in

0805e41

Handle ost

9ad13ed

MapInfoModal, fix lb pfp on first launch with less than 10 cells

82bf098

fix panelview misalignment

2c4c5a2

begin desktop imber ui

9e37d6a

Ensure seperator is not scaled

d53b9ae

Add graphic raycaster and scaler

7f41d33

Display Imber on desktop, not clickable rn

c25e39c

Graphic raycaster on viewcontroller

130bc29

Working imber ui + scrubber, cant move it around yet

d92b5d2

Move desktop imber ui, add settings, bug fixes

e78761b

Add hiding replay watermark if it is the users replay

3a1fdf2

Fix replay sync

60c3dde

Make sure playback is paused while scrubbing

fc4d7ca

Fix legacyreplayplayer throwing

2e7f7d6

Update README.md

80242d5

C to unlock/lock cursor while in replay

46e6902

Merge branch 'main' of https://github.com/speecil/scoresaber-plugin

d8c058f

Make tab selector bigger in imber desktop

5dc64aa

Fix energyplayer

90ed814

smooth profile picture fade in

70a4d95

Improve timebar

602d70e

Qwasyx requested changes Dec 11, 2024

View reviewed changes

speecil added 4 commits December 11, 2024 18:50

Qwasyx Review 1

b0fad27

Qwasyx review 2

5c616cb

Publicize DataModels

0ae231b

bugfix

4e25796

Qwasyx requested changes Dec 11, 2024

View reviewed changes

speecil added 3 commits December 12, 2024 16:30

Qwasyx Review 3

01f5b59

make rich p not on by default, popup modal

0c9bfdf

Qwasyx review 4

14548c0

Umbranoxio mentioned this pull request Dec 14, 2024

Add Map Info Modal #28

Closed

Umbranoxio reviewed Dec 14, 2024

View reviewed changes

speecil added 9 commits December 14, 2024 17:29

Umbra review 1

dfc0c17

rich disclaimer bug fix

16dcb3b

use menu button, umbra review 2

875fd86

Make header use scoresaber diff colours

cd62533

Http client rewrite + small changes

40ae61a

remove static http client, only injection

256182e

Allow OST score uploading

56968cd

Null check levelAuthorName

8711994

Update to 1.40, fix arc replay

3f7ab10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The Everything Update (UI Overhaul + Bug Fixes) #30

The Everything Update (UI Overhaul + Bug Fixes) #30

speecil commented Oct 23, 2024

Qwasyx left a comment

Qwasyx Dec 11, 2024

Qwasyx Dec 11, 2024

speecil Dec 12, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Qwasyx Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024 •

edited

Loading

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

speecil Dec 14, 2024

speecil Dec 14, 2024

Umbranoxio Dec 14, 2024

The Everything Update (UI Overhaul + Bug Fixes) #30

Are you sure you want to change the base?

The Everything Update (UI Overhaul + Bug Fixes) #30

Conversation

speecil commented Oct 23, 2024

Qwasyx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Umbranoxio Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Umbranoxio Dec 14, 2024 •

edited

Loading