Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix around player → country scope change bugs (Fixes #7) #8

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

PulseLane
Copy link
Contributor

@PulseLane PulseLane commented Feb 23, 2023

Changing the scope from "Around me" to the country filtering will result in some inconsistent behavior. None of the scores will load and the up/down arrows on the side on the leaderboard are not properly updated. This is caused by the AroundPlayer hardcodes only checking that the scope matches; however, country filtering is implementing using a bool override for the current scope.

  • Add a check that _filterAroundCountry is not true when checking that the scope is "AroundPlayer"

Fixes #7

@Umbranoxio Umbranoxio merged commit 5604e7b into ScoreSaber:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When switching from "Around You" to "Country" on the Leaderboard no scores are shown
2 participants