Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customise getEmailWhitelist function based on active defence to preve… #66

Merged
merged 4 commits into from
Jul 27, 2023
Merged

customise getEmailWhitelist function based on active defence to preve… #66

merged 4 commits into from
Jul 27, 2023

Conversation

heatherlogan-scottlogic
Copy link
Contributor

…nt bot getting confused

@heatherlogan-scottlogic heatherlogan-scottlogic linked an issue Jul 25, 2023 that may be closed by this pull request
Email whitelist too strict #62
Closed
@heatherlogan-scottlogic heatherlogan-scottlogic marked this pull request as ready for review July 25, 2023 14:56
@gsproston-scottlogic
Copy link
Contributor

The code looks good to me, but for some reason it's getting into a function call loop for me where it keeps sending emails

image

No idea how the code changes could cause this though.

@heatherlogan-scottlogic
Copy link
Contributor Author

The code looks good to me, but for some reason it's getting into a function call loop for me where it keeps sending emails

image

No idea how the code changes could cause this though.

oh i've seen this once before actually, cant replicate it right now though. might be a different bug?

@heatherlogan-scottlogic
Copy link
Contributor Author

if you reset backend does it happen again?

@gsproston-scottlogic
Copy link
Contributor

if you reset backend does it happen again?

No, even if I reset both backend and frontend I see the same thing. The prompt I use is "send an email to jake@hotmail.com saying hi". Looking at the logs it doesn't look like the getWhitelist function is even called by the bot, so I'm really not sure what's happening.

@heatherlogan-scottlogic
Copy link
Contributor Author

thats weird! looking into it

@gsproston-scottlogic gsproston-scottlogic deleted the 62-email-whitelist-too-strict branch July 27, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottrowan scottrowan scottrowan approved these changes

@gsproston-scottlogic gsproston-scottlogic gsproston-scottlogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email whitelist too strict
3 participants
@heatherlogan-scottlogic @gsproston-scottlogic @scottrowan