Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Prisma Client to 5.6 - Resolves Unit Filter Bug #128

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

mgmgperson
Copy link
Contributor

Description

Quick upgrade to Prisma Client from its 4.12 to 5.6. Addresses the bug where the unit count filter was broken.
May need to regenerate database with "npm run db-generate".

Closes #124

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Node.js version:
  • Python version:
  • Desktop/Mobile:
  • OS:
  • Browser:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This pull request updates the Prisma Client from its current version to 5.6. This upgrade addresses several bugs that were identified in the previous versions, including a critical issue with the unit filter functionality.
@mgmgperson mgmgperson changed the title Upgrade Prisma Client to 5.6 - Resolves Unit Filter Bug and Other Issues Upgrade Prisma Client to 5.6 - Resolves Unit Filter Bug Nov 15, 2023
Copy link
Collaborator

@Lhwhatever Lhwhatever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lhwhatever Lhwhatever merged commit 92acfb0 into ScottyLabs:main Nov 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unit count filter is broken
2 participants