Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Department filter search #135

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Department filter search #135

merged 9 commits into from
Feb 16, 2024

Conversation

Xavilien
Copy link
Member

@Xavilien Xavilien commented Feb 13, 2024

Description

Added text input to filter department search for ease of use. Met a number of technical and styling challenges, but I believe this is the best that can be done for now.

Backspace deletes filters, tab autofills the first option if in input mode.

Closes #133

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Type in search query without spaces
  • Type in search query with spaces (this was initially an issue)
  • Add multiple options under the same query
  • Change query after selecting options (query is cleared when reselecting the input)
  • Exiting the input clears the query
  • Backspace deletes the filters until there are non left
  • If in input mode, tab autofills the first option and exits input mode

Test Configuration:

  • Node.js version: v18.18.0
  • Desktop: MacBook Air M2
  • OS: MacOS Sonoma
  • Browser: Safari

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

railway-app bot commented Feb 13, 2024

This PR was not deployed automatically as @Xavilien does not have access to the Railway project.

In order to get automatic PR deploys, please add @Xavilien to your team on Railway.

@Xavilien Xavilien marked this pull request as ready for review February 14, 2024 04:04
Copy link
Collaborator

@Lhwhatever Lhwhatever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Xavilien Xavilien merged commit af8606c into main Feb 16, 2024
1 check passed
@Xavilien Xavilien deleted the department-filter-search branch February 16, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add the ability to type text into the department filter, which supports fuzzy-finding of departments
2 participants