Eventually exception fix #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygoy
approved these changes
Sep 23, 2023
Comment on lines
+304
to
+311
| def test_mention_multiple_errors_once(self, mocked_time, Tester): | ||
| mocked_time.time = mock.create_autospec(time.time, side_effect=[1, 1, 1, 100]) | ||
| mock_question = FakeQuestion() | ||
| mock_question.answered_by.return_value = True | ||
| mock_question.describe.return_value = "returns bool" | ||
|
|
||
| with pytest.raises(DeliveryError) as actual_exception: | ||
| Eventually(See(mock_question, IsEqualTo(False))).perform_as(Tester) |
There was a problem hiding this comment.
Just to make sure, did this test fail before adding the fix above?
Comment on lines
+168
to
+174
| def same_exception(a: BaseException, b: BaseException) -> bool: | ||
| """compare exceptions to see if they match""" | ||
| return ( | ||
| isinstance(a, type(b)) | ||
| and (str(a) == str(b)) | ||
| and (format_tb(a.__traceback__) == format_tb(b.__traceback__)) | ||
| ) |
There was a problem hiding this comment.
Some things i'd like to see for this function:
- The name, maybe
isequal_exception? Kinda likeisinstance? - the parameters, we can do better than
aandb. Maybe evenfirst_excandsecond_exc? - The docstring, i think it can be a little more explicit about what we're doin' here.
There was a problem hiding this comment.
I also have mixed feelings about this function hanging out in Eventually, but i can't figure out what exactly makes me feel like i want to avoid that. It being on the outside means we can use it elsewhere if we need to, which is nice, but is this the right place for it?
There was a problem hiding this comment.
I'm glad you said something. I almost put it into a module called "common" or some such. But YAGNI prevented me. If we ever need the function elsewhere, we can move it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102