Issue 150 alternate #154
Draft
Issue 150 alternate #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions are wrapped in `Silently`
…t why it complains about the docstring formatting
perrygoy
reviewed
Mar 18, 2025
Comment on lines
+72
to
+74
| val | ||
| for action in self.try_performables | ||
| if (val := get_additive_description(action)) |
There was a problem hiding this comment.
praise: I have never used a walrus in a comprehension but honky bunks it works, pretty cool!
There was a problem hiding this comment.
discussion: That said, i think i don't like this side effect of doing the check in get_additive_description. Seeing it in practice now makes me feel like the is_silent approach is the correct one, so each description can decide for itself what to do about silenced ducks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.