Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
…issues-2060 tanstack start rsbuild
|
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c1a6b2c8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!isRedirect(value)) { | ||
| return undefined |
There was a problem hiding this comment.
The new isResponseLike path is intended to support redirects coming from a different runtime realm, but getRedirectOptions immediately calls isRedirect, which still requires instanceof Response. In that case redirectOptions is always undefined, so redirect responses are treated as raw responses (X_TSS_RAW_RESPONSE) instead of serialized redirects, and client server-function calls won't trigger redirect handling. This affects both the success and error branches that now rely on getRedirectOptions.
Useful? React with 👍 / 👎.
| if (!serverBuild?.fetch) { | ||
| return next() | ||
| } | ||
| req.url = joinURL(resolvedStartConfig.viteAppBase, req.url ?? '/') |
There was a problem hiding this comment.
assetPrefix is an absolute URL
This middleware rewrites req.url by prefixing resolvedStartConfig.viteAppBase, but that value is sourced from Rsbuild output.assetPrefix and can be a full CDN URL. When it is absolute (for example https://cdn.example.com/assets/), app requests are rewritten to CDN-prefixed paths before reaching serverBuild.fetch, causing route mismatches/404s in dev (and similarly in the prod middleware path).
Useful? React with 👍 / 👎.
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
…on-refinement-1b7e Branch implementation refinement
Restore the PR GitHub Actions workflow to the main-branch behavior because the quality-audit PR changes were not needed for feat/rsbuild. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Closing this fork PR in favor of opening the same branch against TanStack/router. |
3 participants
No description provided.